Skip to content

Add react-native-reanimated-skeleton#1663

Merged
Simek merged 2 commits intoreact-native-community:mainfrom
metehandemir:patch-1
May 24, 2025
Merged

Add react-native-reanimated-skeleton#1663
Simek merged 2 commits intoreact-native-community:mainfrom
metehandemir:patch-1

Conversation

@metehandemir
Copy link
Copy Markdown
Contributor

✅ Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

"ios": true,
"android": true,
"web": true,
"windows": true,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @metehandemir, thanks for adding new entry to the directory! 👍

Just one thing, adding out-of-tree platforms support requires providing an example for that platform, see:

I was not able to find react-native-windows usage in the whole monorepo. If there is an example outside it, please update the examples array, if not let's remove windows flag for now, until we have a confirmation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it.

Copy link
Copy Markdown
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! 👌

@Simek Simek merged commit efcc11c into react-native-community:main May 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants